huan233usc commented on code in PR #16626:
URL: https://github.com/apache/iceberg/pull/16626#discussion_r3331524864
##########
spark/v4.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -125,6 +126,22 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface)
}
}
+ /**
+ * Parse a string to a LogicalPlan, binding the given parameters.
+ */
+ override def parsePlanWithParameters(
+ sqlText: String,
+ parameterContext: ParameterContext): LogicalPlan = {
+ val sqlTextAfterSubstitution = substitutor.substitute(sqlText)
+ if (isIcebergCommand(sqlTextAfterSubstitution)) {
Review Comment:
Maybe add a documentation to say "Iceberg DDL grammars do not accept
parameter markers (`?` / `:name`)" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
