rdblue commented on a change in pull request #1906:
URL: https://github.com/apache/iceberg/pull/1906#discussion_r540562816
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -76,6 +76,7 @@ callArgument
expression
: constant
+ | stringMap
Review comment:
Actually, we may want to remove `keyValue` and just use `constant` so
that a missing value doesn't result in a parse error. Instead we can give a
better error message in the AST builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
