pvary commented on code in PR #16015:
URL: https://github.com/apache/iceberg/pull/16015#discussion_r3335240919
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -81,6 +87,9 @@ class DynamicWriter implements
CommittingSinkWriter<DynamicRecordInternal, Dynam
this.attemptId = attemptId;
this.taskWriterFactories = new LRUCache<>(cacheMaximumSize);
this.writers = Maps.newHashMap();
+ this.flushExecutor =
Review Comment:
Where do we close the executor?
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -81,6 +87,9 @@ class DynamicWriter implements
CommittingSinkWriter<DynamicRecordInternal, Dynam
this.attemptId = attemptId;
this.taskWriterFactories = new LRUCache<>(cacheMaximumSize);
this.writers = Maps.newHashMap();
+ this.flushExecutor =
Review Comment:
Where do we close the executor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
