rdblue commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3336833348
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -51,7 +51,7 @@ private DeletionVectorStruct(DeletionVectorStruct toCopy) {
}
private DeletionVectorStruct(String location, long offset, long sizeInBytes,
long cardinality) {
Review Comment:
> Is the representation something we are willing to re-consider at this
point?
I would say no. We have been using this pattern for years without issue and
it avoids boxing/unboxing in a tight loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
