ebyhr commented on code in PR #3414:
URL: https://github.com/apache/iceberg-python/pull/3414#discussion_r3337332651
##########
mkdocs/docs/api.md:
##########
@@ -1529,15 +1529,72 @@ cleanup_old_snapshots("analytics.user_events", [12345,
67890, 11111])
## Views
-PyIceberg supports view operations.
+If PyIceberg is unable to automatically determine view support on your REST
Catalog, you can manually specify, `"view-endpoints-supported": "true"`:
-### Check if a view exists
+```python
+from pyiceberg.catalog import load_catalog
+
+catalog = load_catalog(
+ "docs",
+ **{
+ "uri": "http://127.0.0.1:8181";,
+ "s3.endpoint": "http://127.0.0.1:9000";,
+ "py-io-impl": "pyiceberg.io.pyarrow.PyArrowFileIO",
+ "s3.access-key-id": "admin",
+ "s3.secret-access-key": "password",
Review Comment:
nit: We could move the `s3.endpoint` so that we can place S3 properties
close together:
```suggestion
"py-io-impl": "pyiceberg.io.pyarrow.PyArrowFileIO",
"s3.endpoint": "http://127.0.0.1:9000";,
"s3.access-key-id": "admin",
"s3.secret-access-key": "password",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
