huan233usc commented on code in PR #16651:
URL: https://github.com/apache/iceberg/pull/16651#discussion_r3337783717
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -211,6 +223,16 @@ public static Snapshot fromJson(String json) {
return JsonUtil.parse(json, SnapshotParser::fromJson);
}
+ private static String resolveManifestList(String manifestList, String
tableLocation) {
Review Comment:
nit: should we consider using Optional<String>? (personally I don't like
play with `null`s)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
