gaborkaszab commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3339960332
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -79,7 +84,7 @@ private TrackingStruct(TrackingStruct toCopy) {
this.manifestPos = toCopy.manifestPos;
}
- private TrackingStruct(
+ TrackingStruct(
Review Comment:
Not sure I see the benefit of keeping it separate within this PR and move it
back later on. Can we do it now? Unless we have a TODO here that at some time
we have to change the visibility of the constructor, there is a chance we
forget it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]