Sidra-009 commented on code in PR #3451:
URL: https://github.com/apache/iceberg-python/pull/3451#discussion_r3346389856


##########
tests/integration/test_writes/test_writes.py:
##########
@@ -870,7 +870,9 @@ def test_summaries_with_only_nulls(
 @pytest.mark.integration
 def test_duckdb_url_import(warehouse: Path, arrow_table_with_null: pa.Table) 
-> None:
     os.environ["TZ"] = "Etc/UTC"
-    time.tzset()
+
+    if hasattr(time, "tzset"):
+        time.tzset()

Review Comment:
   thanks for the review i will split this PR into separate changes as 
suggested:
   
   - COS documentation update
   - Windows tzset fix
   - markdownlint formatting fixes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to