danielcweeks commented on code in PR #16394:
URL: https://github.com/apache/iceberg/pull/16394#discussion_r3349285260
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2019,6 +2058,52 @@ components:
explode: false
example: "vended-credentials,remote-signing"
+ client-capabilities:
Review Comment:
I'm not sure this is the right way to go about this. The more I think about
what we're doing here, the more concerned I get that what we're really doing is
creating a clever way to workaround the right way to do this, which is using
versioned endpoints.
Capabilities like read restrictions means you're changing the semantics of
the endpoint but rather than forcing clients through a new path, we're
triggering different behavior based on sidecar information (in this case
headers).
Why not introduce a loadTable v2? We can handle a number of issues that
have come up in the past:
- credentials in both config and the storage creds structure
- how to handle tables with scan plan but we don't want to expose snapshots
- read restrictions must be understood
I just feel like the right way to do this would be just spec out a `v2`
endpoint and address many of these concerns at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
