rambleraptor commented on code in PR #3423:
URL: https://github.com/apache/iceberg-python/pull/3423#discussion_r3351588627
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -435,7 +436,32 @@ def _create_session(self) -> Session:
elif ssl_client_cert := ssl_client.get(CERT):
session.cert = ssl_client_cert
- if auth_config := self.properties.get(AUTH):
+ raw_auth = self.properties.get(AUTH)
+ if isinstance(raw_auth, str):
+ try:
+ auth_config: dict[str, Any] | None = json.loads(raw_auth)
+ except json.JSONDecodeError as e:
+ raise ValueError("Failed to parse auth configuration as JSON")
from e
+ elif raw_auth is not None:
+ auth_config = raw_auth
+ elif auth_type := self.properties.get(f"{AUTH}.type"):
+ type_prefix = f"{AUTH}.{auth_type}."
+ auth_config = {
Review Comment:
Thought: Right now, properties is a dict[str, Any], so auth_config is a
`dict[str, Any]`. We should have a type signature for the different parts. I'd
love to have type checking on these auth properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
