rambleraptor commented on code in PR #3207:
URL: https://github.com/apache/iceberg-python/pull/3207#discussion_r3352048157
##########
tests/expressions/test_parser.py:
##########
@@ -272,3 +282,94 @@ def test_valid_between_with_numerics() -> None:
) == parser.parse("foo between '2025-01-01T00:00:00.000000' and
'2025-01-10T12:00:00.000000'")
assert parser.parse("foo between 1 and 3") == parser.parse("1 <= foo and
foo <= 3")
+
+
+def test_cast_date_comparison() -> None:
+ expected = EqualTo(
+ UnboundTransform(Reference("created_at"), DayTransform()),
+ StringLiteral("2024-01-01"),
+ )
+ assert expected == parser.parse("CAST(created_at AS date) = '2024-01-01'")
+
+
+def test_cast_date_binds_string_literal_to_date() -> None:
Review Comment:
We should have more tests like this with uneven types. I posted an example
in another comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
