Revanth14 commented on PR #1163: URL: https://github.com/apache/iceberg-go/pull/1163#issuecomment-4619494096
> LGTM! > > One thing to fix before merge: > > The proxy/timeout paths previously inherited the SDK default `MaxConnsPerHost = 2048`, and this PR brings them down to `s3MaxConnsPerHost = 256` to match the no-proxy default. That's a real cap reduction for anyone running heavy parallel S3 traffic through a proxy. Either call this out explicitly in the PR description as an intentional consistency change, or bump `s3MaxConnsPerHost` back up to 2048 (and keep the other three at 256) so the proxy/timeout paths don't regress on concurrency. Thanks, fixed it. I bumped `MaxConnsPerHost` to `2048` so the proxy/connect-timeout paths keep the previous SDK concurrency cap, while the idle connection tuning remains at `256`/`90s`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
