wgtmac commented on code in PR #694:
URL: https://github.com/apache/iceberg-cpp/pull/694#discussion_r3354549194
##########
.github/.licenserc.yaml:
##########
@@ -31,5 +31,6 @@ header:
- 'requirements.txt'
- 'src/iceberg/util/murmurhash3_internal.*'
- 'src/iceberg/test/resources/**'
+ - 'third_party/**'
Review Comment:
Should we rename `third_party` to `thirdparty` which is more widely used?
##########
NOTICE:
##########
@@ -3,3 +3,8 @@ Copyright 2024-2026 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+Third-party Thrift IDLs vendored under third_party/hive_metastore/ are
Review Comment:
IIUC, ASF projects are exempted here. cc expert @jbonofre
##########
third_party/hive_metastore/NOTICE:
##########
@@ -0,0 +1,26 @@
+Apache Iceberg C++ — Vendored Hive Metastore Thrift IDL
+Copyright 2026 The Apache Software Foundation
+
+This directory contains vendored Thrift interface definitions used to
+generate the C++ Hive Metastore (HMS) client consumed by the
+`iceberg_hive` library. The interface files are sourced verbatim from
+upstream Apache projects (only trailing whitespace and final newlines
+were normalized by the repository's pre-commit hooks) and remain under
+the Apache License, Version 2.0 (see LICENSE in the repository root).
+
+Vendored sources
+================
+
+* hive_metastore.thrift
+ Apache Hive 3.1 standalone-metastore.
Review Comment:
Why this specific version? How do we want to upgrade or maintain multiple
versions in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
