pvary commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3354756148
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -1803,41 +1899,66 @@ private static void assertBounds(
Map<Integer, ByteBuffer> lowerBounds = file.lowerBounds();
Map<Integer, ByteBuffer> upperBounds = file.upperBounds();
+ if (genericRecords.isEmpty()) {
+ return;
+ }
Review Comment:
Should this be a precondition?
This should not really happen, and likely a result of a bug if we try to
check empty records
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -792,6 +887,7 @@ void testDataWriterMetricsWithNoneMode(FileFormat
fileFormat) throws IOException
void testDataWriterMetricsWithCountsMode(FileFormat fileFormat) throws
IOException {
DataGenerator dataGenerator = new DataGenerators.DefaultSchema();
Schema schema = dataGenerator.schema();
+
Review Comment:
nit: unneccesary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
