lilei1128 commented on code in PR #16523:
URL: https://github.com/apache/iceberg/pull/16523#discussion_r3356072936
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -740,6 +740,45 @@ public void simpleTypesInFilter() {
sql("DROP TABLE IF EXISTS %s", tableName);
}
+ @TestTemplate
+ public void testTimeTravelFilterOnRenamedColumn() {
Review Comment:
Added the test to v4.1 as well. All three module copies (v3.5, v4.0, v4.1)
are now identical, with distributed planning enabled.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -696,6 +696,50 @@ public void
testRequiredNestedFieldInOptionalStructFilter() {
sql("DROP TABLE IF EXISTS %s", nestedStructTable);
}
+ @TestTemplate
+ public void testTimeTravelFilterOnRenamedColumn() {
+ // create a separate table for this test
Review Comment:
Removed this redundant code comment.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -696,6 +696,50 @@ public void
testRequiredNestedFieldInOptionalStructFilter() {
sql("DROP TABLE IF EXISTS %s", nestedStructTable);
}
+ @TestTemplate
+ public void testTimeTravelFilterOnRenamedColumn() {
+ // create a separate table for this test
+ String ttTableName = tableName("tt_rename_table");
+ sql("DROP TABLE IF EXISTS %s", ttTableName);
+ sql("CREATE TABLE %s (id BIGINT, col DOUBLE) USING iceberg", ttTableName);
Review Comment:
Good catch! Added read.data-planning-mode=distributed and
read.delete-planning-mode=distributed to the table properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
