pvary commented on code in PR #16545: URL: https://github.com/apache/iceberg/pull/16545#discussion_r3356888964
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/source/reader/WakeableIterator.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.source.reader; + +import org.apache.iceberg.io.CloseableIterator; + +/** + * A {@link CloseableIterator} that can be woken up while it is blocked producing the next element. + * + * <p>This lets {@link IcebergSourceSplitReader#wakeUp()} unblock a fetcher thread that is waiting + * for an array-pool entry in {@link ArrayPoolDataIteratorBatcher} so that the thread can return + * control and exit cleanly during shutdown. The {@link + * org.apache.flink.connector.base.source.reader.splitreader.SplitReader#fetch()} call stays + * reentrant: after being woken the next {@code fetch()} simply resumes. Review Comment: Remove this, we don't need to describe the Flink internals here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
