c-thiel commented on code in PR #2188: URL: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3357634867
########## crates/iceberg/src/spec/schema/prune_columns.rs: ########## Review Comment: Added `test_prune_columns_variant` — a variant prunes like a primitive leaf: selecting it keeps it (same for full and non-full projection), selecting a sibling drops it. I also mirrored Java's `TestTypeUtil` variant coverage for the other arms this PR touched: t`est_reassign_ids_variant` (id_reassigner) and `test_assign_fresh_ids_variant` (schema-evolution id assignment). Added in https://github.com/apache/iceberg-rust/pull/2188/commits/1673a2b22ea0bcb4d9804ccb34104528e68837fe Do you think anything else is missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
