kszucs commented on code in PR #2588:
URL: https://github.com/apache/iceberg-rust/pull/2588#discussion_r3358156458


##########
crates/storage/opendal/src/gcs.rs:
##########
@@ -46,15 +46,15 @@ pub(crate) fn gcs_config_parse(mut m: HashMap<String, 
String>) -> Result<GcsConf
     }
 
     if m.remove(GCS_NO_AUTH).is_some() {
-        cfg.allow_anonymous = true;

Review Comment:
   > S3-compatible services now use skip_signature for unsigned requests. S3, 
OSS, and GCS keep allow_anonymous as a deprecated alias; TOS users must migrate 
to skip_signature because allow_anonymous has been removed. GCS skip_signature 
now unconditionally bypasses signing instead of falling back on credential 
errors.
   
   see changelog https://github.com/apache/opendal/releases/tag/v0.57.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to