rdblue commented on code in PR #16652:
URL: https://github.com/apache/iceberg/pull/16652#discussion_r3358179933


##########
format/expressions-spec.md:
##########
@@ -0,0 +1,284 @@
+---
+title: "Expressions Spec"
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Iceberg Expressions
+
+This document defines the structure and behavior of expressions for use in 
Iceberg specifications. The purpose is to define a common structure that 
enables simple expressions to be stored and exchanged.
+
+Stored expressions are needed for use cases like data validations (`CHECK` 
constraints) and default values (for instance, `current_timestamp()`). 
Expressions are exchanged in use cases like server-side scan planning in the 
catalog protocol.
+
+
+## Overview
+
+The goal of this specification is to define a simple expression structure and 
avoid complexity.
+
+To remain simple, the expressions that can be represented are deliberately 
constrained. Value expressions are constants, field references, or function 
calls with value expression arguments. Predicates are comparisons of value 
expressions that produce true or false.
+
+This approach is intended to keep focus on the logical structure of 
expressions. Complexity is pushed to the functions that are called, which can 
be a limited set of well-defined and portable functions (like Iceberg partition 
transforms) or could be user-defined functions that can use the full range of 
SQL capabilities. Multi-dialect UDFs are responsible for any SQL constructs 
that are specific to an engine, rather than importing and duplicating dialects 
in Iceberg expressions.
+
+This is consistent with Iceberg's conservative approach in other specs. 
Expressions and predicates are an important part of Iceberg implementation 
APIs, but have been deliberately limited in specifications. For example, sort 
orders and partition fields are strictly limited to a small set of transforms 
over well-defined inputs (source field IDs). This spec is widening what can be 
expressed, but depends on function calls for complex tasks.
+
+This specification covers the structure of Iceberg expressions and includes 
appendicies that specify serialization as JSON and a set of portable functions 
defined by Iceberg specifications.
+
+
+## Structure
+
+Iceberg expressions have two types:
+
+* **Value expressions** represent data values and transformations of values 
(function calls) that produce any Iceberg type
+* **Predicates** represent comparisons of value expressions and boolean logic 
that produce `true` or `false`
+
+
+### Value expressions
+
+A value expression is an expression that produces a typed value
+
+Value expressions can be one of three types: a constant value, a field 
reference, or a function applied to zero or more value expressions.
+
+
+#### Constant values
+
+A constant or literal is the simplest type of value expression that represents 
a specific typed value.
+
+
+#### Field reference
+
+A field reference represents the value of a specific field in a row. When an 
expression is evaluated on a row, it returns the value of the field.
+
+Field references may be named references (unbound) or ID references (bound). 
ID references identify a field by field ID from a schema. Named references 
identify a field by name that must be resolved to an ID (bound to a schema) to 
access the field.
+
+ID references are used for stored expressions, where the identity of the 
column is determined when the stored expression is created. For example, column 
constraints are tied to field ID so that renaming a column does not drop its 
stored constraint.
+
+Named references are used when the identity of the column is determined when 
the expression is evaluated. For example, query filters are resolved each time 
a query runs so servers-side planning uses unbound named references.
+
+The context in which an expression is used determines the type of references 
that are valid. Iceberg specifications should document whether ID references, 
named references, or both are allowed.
+
+
+#### Apply function
+
+An apply expression represents the result of a function applied to (or called 
on) zero or more values produced by child value expressions.
+
+Functions are identified by catalog, namespace, and name.
+
+* Function name is always required
+* Namespace is optional and is assumed to be empty ([]) if it is not present 
or is null
+* Catalog is optional and is assumed to be the catalog in which the 
referencing object is stored if it is not present or is null
+
+The catalog name is used to identify the catalog where the function definition 
can be loaded or it identifies a reserved function set. As in the view and UDF 
specs, catalog names represent connection configurations that may differ across 
environments. Omitting catalog names is recommended to avoid depending on 
consistent environments. For example, if a table has a CHECK constraint that 
references a UDF without a catalog name (missing or null), the UDF should be 
loaded from the table’s catalog.
+
+Reserved function set names are:
+
+* `sql_functions` is used for functions defined by the SQL standard
+* `iceberg_functions` is used for functions defined in this specification
+
+Engines may document and use a catalog name to identify their built-in 
functions that are not part of the SQL spec, like 
`spark_builtin_functions.to_utc_timestamp`.
+
+Producers are responsible for resolving catalog, namespace, and name if the 
environment is relevant. For example, if a SQL engine uses its current catalog 
and namespace to find a function, the resolved catalog and namespace must be 
used to produce an unambiguous function identifier.
+
+
+#### Value expression types
+
+The type produced by a value expression may change. For example, an ID 
reference may produce a widened type after the underlying column's type is 
promoted.
+
+Function calls may produce different types when function definitions change, 
and type changes may change the definition that is resolved for a function 
name. For example, `identity(int) -> int` will change to `identity(long) -> 
long` when an input field is promoted from `int` to `long`.
+
+A value expression's type is determined when it is bound to a specific input 
schema.
+
+If types are incompatible at runtime, implementations binding or evaluating 
expressions may apply type promotion to align types for predicates and to 
resolve functions. Implementations may choose when to promote values to 
accomodate engines that differ in casting behavior. However, implementations 
must fail rather than insert "unsafe" casts. 
+
+
+### Predicates
+
+A predicate is a boolean expression that produces true or false.
+
+Predicates can be constants (true or false), comparisons or tests of value 
expressions, or logical combinations of predicates (AND, OR, NOT).
+
+If value expression types in a predicate are incompatible, implementations 
should align types using type promotion. For instance, `int_col > 5.0` should 
promote int values to float. If the types cannot be aligned according to type 
promotion rules, the predicate must evaluate to false. For instance, `"goats" > 
-Infinity` should always be `false`.
+
+Value expressions are not valid predicates, even when the expression is 
expected to return a boolean value. Value expressions must be compared or 
tested to produce a predicate. For example, `is_empty("")` is not a valid 
predicate, but `is_empty("") = true` is a valid predicate.
+
+
+#### Comparisons
+
+Comparisons are predicates that compare two value expressions with the same 
primitive type. Comparisons are:
+
+| Comparison  | Description |
+|-------------|-------------|
+| `=`         | Is equal |
+| `!=`        | Is not equal |
+| `<`         | Less than |
+| `<=`        | Less than or equal |
+| `>`         | Greater than |
+| `>=`        | Greater than or equal |
+
+Primitive types are compared using natural order, except for the following 
types:

Review Comment:
   Yeah, I was wondering how to put this. Looks like Parquet uses "signed 
comparison" 
([thrift](https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L1081)),
 I'll update to use that instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to