zhjwpku commented on code in PR #693: URL: https://github.com/apache/iceberg-cpp/pull/693#discussion_r3359709195
########## CMakeLists.txt: ########## @@ -46,6 +46,12 @@ option(ICEBERG_BUILD_BUNDLE "Build the battery included library" ON) option(ICEBERG_BUILD_REST "Build rest catalog client" ON) option(ICEBERG_BUILD_REST_INTEGRATION_TESTS "Build rest catalog integration tests" OFF) option(ICEBERG_BUILD_HIVE "Build hive (HMS) catalog client" OFF) +option(ICEBERG_BUILD_SQL_CATALOG "Build SQL catalog client" ON) Review Comment: REST catalog is `ON` by default, but I'd agree that we should make SQL catalog OFF, changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
