dannycjones commented on code in PR #2589:
URL: https://github.com/apache/iceberg-rust/pull/2589#discussion_r3363312846
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -483,27 +483,37 @@ fn update_totals(
added_property: &str,
removed_property: &str,
) {
- let previous_total = previous_summary.map_or(0, |previous_summary| {
- previous_summary
- .additional_properties
- .get(total_property)
- .map_or(0, |value| value.parse::<u64>().unwrap())
- });
+ let previous_total = match previous_summary {
+ Some(previous_summary) => {
+ match previous_summary.additional_properties.get(total_property) {
+ Some(value) => match value.parse::<u64>() {
+ Ok(v) => v,
+ Err(e) => {
+ tracing::warn!(
+ "Failed to parse previous summary property
'{total_property}' value '{value}': {e}. \
+ Skipping total computation.",
+ );
+ return;
+ }
+ },
+ None => return,
+ }
+ }
+ None => 0,
+ };
let mut new_total = previous_total;
- if let Some(value) = summary
- .additional_properties
- .get(added_property)
- .map(|value| value.parse::<u64>().unwrap())
- {
- new_total += value;
+ if let Some(value) = summary.additional_properties.get(added_property) {
+ match value.parse::<u64>() {
+ Ok(v) => new_total += v,
+ Err(_) => return,
Review Comment:
I've pushed a change which updates `build(&self)` to `build(&self,
prev_summary: Option<&Summary>)`.
This allows us to access the collected metrics directly rather than
serializing and deserializing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
