huaxingao commented on PR #15180: URL: https://github.com/apache/iceberg/pull/15180#issuecomment-4636575620
Thanks @szehon-ho for your comment! On the `specific name`, yes, `definition-id` already serves that role in the model. Each `FunctionDefinition` carries a `definition-id` that uniquely identifies one overload within a function. That maps to the SQL standard's `specific name` concept. On `function` vs `routine`: I think you're right that it's late to change. The term `function` matches what engines (Spark, Trino, Snowflake, etc.) expose in their public APIs and is already used throughout Iceberg (FunctionCatalog, the UDF spec doc, etc.). Happy to add a note in the UDF spec that the `function` maps to SQL-standard `routine` concepts if that's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
