Fokko commented on code in PR #3448:
URL: https://github.com/apache/iceberg-python/pull/3448#discussion_r3366886708
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1676,22 +1676,18 @@ def _task_to_record_batches(
# Create the mask of indices that we're interested in
indices = _combine_positional_deletes(positional_deletes,
current_index, current_index + len(batch))
current_batch = current_batch.take(indices)
+ if pyarrow_filter is not None:
+ try:
+ current_batch = current_batch.filter(pyarrow_filter)
+ except IndexError:
+ # PyArrow < 21 raises IndexError when filter produces
zero rows
+ # (fixed in https://github.com/apache/arrow/pull/46057)
+ current_batch = current_batch.slice(0, 0)
Review Comment:
How about?
```suggestion
if pyarrow_filter is not None and len(current_batch) > 0:
current_batch = current_batch.filter(pyarrow_filter)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
