GayathriSrividya commented on code in PR #3461:
URL: https://github.com/apache/iceberg-python/pull/3461#discussion_r3366905044
##########
pyiceberg/table/__init__.py:
##########
@@ -1245,6 +1246,14 @@ def scan(
An integer representing the number of rows to
return in the scan result. If None, fetches all
matching rows.
+ dictionary_columns:
Review Comment:
Good point @Fokko I have moved `dictionary_columns` off the public `scan()`
API and onto the Arrow-specific output methods instead:
```python
table.scan(...).to_arrow(dictionary_columns=("payload",))
table.scan(...).to_arrow_batch_reader(dictionary_columns=("payload",))
```
That way it doesn't pollute the general scan interface. `ArrowScan` still
accepts it for lower-level use. Pushed in the latest commit. Let me know if you
have any further suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
