gty404 commented on code in PR #694: URL: https://github.com/apache/iceberg-cpp/pull/694#discussion_r3367097055
########## third_party/hive_metastore/NOTICE: ########## @@ -0,0 +1,26 @@ +Apache Iceberg C++ — Vendored Hive Metastore Thrift IDL +Copyright 2026 The Apache Software Foundation + +This directory contains vendored Thrift interface definitions used to +generate the C++ Hive Metastore (HMS) client consumed by the +`iceberg_hive` library. The interface files are sourced verbatim from +upstream Apache projects (only trailing whitespace and final newlines +were normalized by the repository's pre-commit hooks) and remain under +the Apache License, Version 2.0 (see LICENSE in the repository root). + +Vendored sources +================ + +* hive_metastore.thrift + Apache Hive 3.1 standalone-metastore. + Source: https://github.com/apache/hive/blob/branch-3.1/standalone-metastore/src/main/thrift/hive_metastore.thrift Review Comment: Should we also pin the exact upstream commit SHAs (or tags) for the vendored files in third_party/hive_metastore/NOTICE or a README so provenance is reproducible and future updates are deterministic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
