anoopj commented on code in PR #16695:
URL: https://github.com/apache/iceberg/pull/16695#discussion_r3368533254
##########
core/src/main/java/org/apache/iceberg/SystemConfigs.java:
##########
@@ -61,6 +61,24 @@ private SystemConfigs() {}
1,
Integer::parseUnsignedInt);
+ /**
+ * Sets the size of the thread pool used for asynchronous REST metrics
reporting. Each thread
+ * issues one HTTP POST concurrently against the metrics endpoint.
+ *
+ * <p>The default of 1 is suitable for short-lived batch jobs where a single
background thread can
Review Comment:
The Java doc is a bit overspecified. Perhaps condense it?
##########
core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java:
##########
@@ -36,8 +36,11 @@
class RESTMetricsReporter implements MetricsReporter {
private static final Logger LOG =
LoggerFactory.getLogger(RESTMetricsReporter.class);
+ // Best-effort async reporting: callers enqueue and return immediately.
Defaults to a single
Review Comment:
Do we really need this config? Did you run into issues with just having one
thread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
