qzyu999 commented on issue #929: URL: https://github.com/apache/iceberg-go/issues/929#issuecomment-4641168960
Hi all, found a second, arguably higher-impact bug in `arrow-go`'s variant implementation that affects the read path, and submitted a fix for it: * Issue: apache/arrow-go#842 * PR: apache/arrow-go#841 **Summary of the bug:** The custom binary search in `ObjectValue.ValueByKey` (activated when objects have $\ge 32$ fields) uses an exclusive upper bound, but updates its bounds using `j = mid - 1`. This incorrectly excludes the element at `mid - 1` from the search space, causing lookup queries to silently fail and return `arrow.ErrNotFound` for keys that actually exist. Since this affects the reading/querying side of Variant objects, users querying nested fields of Variant data loaded via `iceberg-go` will hit this bug. We will definitely want to pull this fix in along with the previous one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
