dttung2905 opened a new pull request, #1172: URL: https://github.com/apache/iceberg-go/pull/1172
## Summary Fix `fetchPartitionSpecFilteredManifests` so manifest partition evaluator failures propagate as errors instead of silently dropping manifests. Adds a regression test ensuring PlanFiles fails when manifest filtering errors occur. ## Issue During scan planning, fetchPartitionSpecFilteredManifests used slices.DeleteFunc with: https://github.com/apache/iceberg-go/blob/e5f4a11744004f5a0a86549bbe8f6e6dd5f2a272/table/scanner.go#L559-L567 When eval(mf) returned an error (e.g. corrupt or incompatible partition summary bounds), the manifest was treated as excluded and removed from the scan. The function still returned nil error, so PlanFiles could return incomplete file tasks with no indication anything went wrong — potentially hiding data that should have been read. `classifyFilesForFilteredDeletions` in transaction.go already propagates this class of error correctly; scan planning did not. https://github.com/apache/iceberg-go/blob/e5f4a11744004f5a0a86549bbe8f6e6dd5f2a272/table/transaction.go#L1420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
