c-thiel commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r3369204539


##########
open-api/rest-catalog-open-api.py:
##########
@@ -1873,6 +2096,13 @@ class PlanTableScanResult(
 CreateTableRequest.model_rebuild()
 CreateViewRequest.model_rebuild()
 ScanReport.model_rebuild()
+QueryEventsResponse.model_rebuild()
+Event.model_rebuild()
+CreateTableOperation.model_rebuild()
+RegisterTableOperation.model_rebuild()
+UpdateTableOperation.model_rebuild()
+CreateViewOperation.model_rebuild()
+UpdateViewOperation.model_rebuild()

Review Comment:
   This section is auto-generated. `model_rebuild()` is a pydantic v2 step that 
`datamodel-code-generator` emits only for models with forward references 
needing late resolution. The listed operations (`CreateTableOperation`, 
`RegisterTableOperation`, `UpdateTableOperation`, `CreateViewOperation`, 
`UpdateViewOperation`) are the ones carrying `updates`/`requirements` that 
reference `TableUpdate`/`ViewUpdate`/`TableRequirement`; the 
drop/rename/namespace ops have no forward refs, so they're omitted. Not a spec 
inconsistency — just which generated classes have forward references.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to