wombatu-kun commented on code in PR #16612:
URL: https://github.com/apache/iceberg/pull/16612#discussion_r3369437321
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -302,4 +320,50 @@ public static Schema fromJson(JsonNode json) {
public static Schema fromJson(String json) {
return SCHEMA_CACHE.get(json, jsonKey -> JsonUtil.parse(json,
SchemaParser::fromJson));
}
+
+ private static class StructDefaultLiteral implements Literal<StructLike> {
Review Comment:
This reimplements `Literal` as a private inner class in core. The co-pending
#15977 adds the parallel `NullLiteral` in
`org.apache.iceberg.expressions.Literals` behind a public `Literal.ofNull()`
factory and edits the same `Types.castDefault`. Consider placing this in
`Literals` behind a public factory for consistency and reuse; otherwise the two
PRs diverge on `castDefault` and on where default literals live.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
