shangxinli commented on code in PR #649: URL: https://github.com/apache/iceberg-cpp/pull/649#discussion_r3369614878
########## src/iceberg/util/thread_pool_internal.h: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <condition_variable> +#include <cstddef> +#include <functional> +#include <future> +#include <mutex> +#include <queue> +#include <span> +#include <thread> +#include <utility> +#include <vector> + +#include "iceberg/iceberg_export.h" + +namespace iceberg { + +/// \brief Fixed-size worker pool for fire-and-wait task batches. +/// +/// Internal API: not part of the public iceberg surface. Used today by +/// FileCleanupStrategy in update/expire_snapshots.cc to parallelize bulk deletes +/// without spawning a fresh std::thread per call. Workers are created eagerly in +/// the constructor and joined in the destructor. +/// +/// All public methods are thread-safe. +class ICEBERG_EXPORT ThreadPool { Review Comment: Heads up @wgtmac — quick self-review pass after the rebase, force-pushed as `70d507d` (amends `7a329ad`): - Renamed the new setter `Executor()` → `ExecuteDeleteWith()` to match Java's `executeDeleteWith(ExecutorService)` and remove the name shadow over `iceberg::Executor`. - Sharpened the comment above the bulk-path `RetryRunner` to be honest about its limits: it helps atomic-bulk FileIO impls (e.g. S3 `DeleteObjects`); for the default fail-fast iterative impl a retried attempt re-submits the full path list and may short-circuit early on `kNotFound`. Still best-effort, no worse than the prior un-retried call. - Refreshed the PR description body — it had been describing the old `std::async`-based approach. No behavioural changes vs `7a329ad`; same 26 tests passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
