joyhaldar commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3374047766
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -2257,4 +2623,13 @@ private void readAndAssertEngineRecords(
assertEquals(
readSchema, convertToEngineRecords(expectedGenericRecords,
readSchema), readRecords);
}
+
+ private Schema primitiveDefaultsReadSchema() {
+ Schema schema = DataGenerators.PrimitiveDefaults.READ_SCHEMA;
+ if (supportsTime()) {
+ return schema;
+ }
+
+ return TypeUtil.selectNot(schema,
Set.of(schema.findField("time_with_default").fieldId()));
Review Comment:
Rebased on main and switched to the `filterUnsupported` mechanism, removed
`supportsTime()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
