rdblue commented on a change in pull request #1919:
URL: https://github.com/apache/iceberg/pull/1919#discussion_r541474399
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -463,8 +464,8 @@ public Builder truncate(String sourceName, int width) {
}
public Builder alwaysNull(String sourceName, String targetName) {
- checkAndAddPartitionName(targetName);
Types.NestedField sourceColumn = findSourceColumn(sourceName);
+ checkAndAddPartitionName(targetName, sourceColumn.fieldId()); // can
duplicate a source column name
Review comment:
Needed to allow identity partitions that have been deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
