wombatu-kun commented on code in PR #16317:
URL: https://github.com/apache/iceberg/pull/16317#discussion_r3377290455
##########
docs/docs/configuration.md:
##########
@@ -48,6 +48,7 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.parquet.page-size-bytes | 1048576 (1 MB)
| Parquet page size
|
| write.parquet.page-version | v1
| Parquet data page version: v1 (DataPage V1) or v2 (DataPage V2)
|
| write.parquet.page-row-limit | 20000
| Parquet page row limit
|
+| write.parquet.row-group-row-limit | 2147483647 (INT_MAX)
| Parquet row group row count limit; row groups are flushed once this many
rows have been written
|
Review Comment:
This table renders an effectively-unlimited MAX default as the constant plus
its effect, not the raw value - see configuration.md:131, `Long.MAX_VALUE`
(forever). `(INT_MAX)` restates the number rather than its meaning and is not
Java naming (it would be `Integer.MAX_VALUE`). Suggest `Integer.MAX_VALUE` (no
limit) to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
