Guosmilesmile commented on code in PR #16724: URL: https://github.com/apache/iceberg/pull/16724#discussion_r3380044922
########## data/src/test/java/org/apache/iceberg/data/FileFormatTestSupport.java: ########## @@ -58,4 +59,6 @@ void writeRecordsWithoutFieldIds(OutputFile outputFile, Schema schema, List<Reco String metadataValue(InputFile inputFile, String key) throws IOException; String splitSizeProperty(); + + void assertEncryptedFileUnreadable(ThrowingCallable readEncryptedFile); Review Comment: Sorry, I left something out. What I'm doing now is checking that the write is encrypted by reading the encrypted file with a normal reader that doesn't have the encryption information, and verifying it through the thrown exception — the exception indicates that the read is missing the key. My understanding is that different file types would throw different exceptions, which is why I wanted more format-specific methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
