marton-bod commented on a change in pull request #1920:
URL: https://github.com/apache/iceberg/pull/1920#discussion_r541574500
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -85,7 +86,11 @@ public void configureInputJobProperties(TableDesc tableDesc,
Map<String, String>
map.put(InputFormatConfig.TABLE_IDENTIFIER,
props.getProperty(Catalogs.NAME));
map.put(InputFormatConfig.TABLE_LOCATION, table.location());
map.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
+ if (table instanceof BaseTable) {
Review comment:
Maybe it's better to check the instance of against `HasTableOperations`,
in case some Table class other than BaseTable will decide to implement this
interface in the future and expose operations on the table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
