anoopj commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3385020433
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -101,33 +100,35 @@ private TrackingBuilder(Tracking source, long
newSnapshotId) {
/** Indicates that the DV has been updated for the new Tracking. */
TrackingBuilder dvUpdated() {
- // DV applies to data files; deleted/replaced positions apply to manifest
files
- Preconditions.checkState(
- deletedPositions == null && replacedPositions == null,
- "Cannot mark DV updated on a manifest entry (deleted/replaced
positions are set)");
this.dvSnapshotId = newSnapshotId;
Review Comment:
yes, the check on `dvSnapshotId` was not useful after we changed the
position setters advance `dvSnapshotId`. Dropping it was intentional. But I
think the check on `dvUpdated` is still useful. Added it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
