amogh-jahagirdar commented on PR #16737:
URL: https://github.com/apache/iceberg/pull/16737#issuecomment-4666485228

   Hey this backport looks a bit different than the original so I think we 
should make sure to call this out in the description. I don't see anything 
wrong with it but from looking at it the main difference looks to be around 
some APIs for NativeEncryptionKeyMetadata that existed on 1.10.x and not on 
master. On 1.10.x, NativeEncryptionKeyMetadata only has encryptionKey() and 
aadPrefix(), and it looks like fileLength isn't there. Readers on 1.10.x 
decrypt DVs using just those two fields. copyWithLength() was added after 1.10.
   
   @manuzhang Is my understanding correct? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to