venkateshwaracholan commented on PR #16615:
URL: https://github.com/apache/iceberg/pull/16615#issuecomment-4668122802
> @venkateshwaracholan can you point to what is creating these warehouse
directories? Are these tests in the Iceberg code base or experiments and
configuration that you have in your environment?
>
> The description says the directory "can create", but it's not clear what's
causing this behavior and if that behavior is expected or not.
Thanks for the question.
This isn't coming from Iceberg CI tests—Spark tests use temporary
directories rather than a repo-root `warehouse/` (for example,
`TestBaseWithCatalog` uses `File.createTempFile("warehouse", ...)`).
The `warehouse/` directory comes from the documented Spark quickstart
(`spark.sql.catalog.local.warehouse=$PWD/warehouse` in
`site/docs/spark-quickstart.md`). I reproduced this locally: creating a table
with that configuration generated files such as:
`warehouse/repro/demo/metadata/v1.metadata.json`
`warehouse/repro/demo/metadata/version-hint.text`
Without the ignore entry, Git reports `?? warehouse/` and `git add .` picks
up those generated files.
Since the repository already ignores similar local runtime directories such
as `spark-warehouse/` and `metastore_db/`, this change adds the path used by
the documented quickstart workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
