dannycjones commented on code in PR #2595:
URL: https://github.com/apache/iceberg-rust/pull/2595#discussion_r3387801328
##########
crates/catalog/s3tables/src/catalog.rs:
##########
@@ -240,7 +240,21 @@ impl S3TablesCatalog {
.table_bucket_arn(self.config.table_bucket_arn.clone())
.namespace(table_ident.namespace().to_url_string())
.name(table_ident.name());
- let resp: GetTableOutput =
req.send().await.map_err(from_aws_sdk_error)?;
+
+ let resp = req.send().await.map_err(|err| {
+ if err
+ .as_service_error()
+ .is_some_and(GetTableError::is_not_found_exception)
+ {
+ Error::new(
+ ErrorKind::TableNotFound,
Review Comment:
Sounds good. I've also updated the error message itself to include this, so
when this error is thrown there is a hint to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
