tanmayrauth commented on code in PR #1179:
URL: https://github.com/apache/iceberg-go/pull/1179#discussion_r3385623436
##########
manifest.go:
##########
@@ -1848,6 +1848,10 @@ func (d *dataFile) initColumnStatsData() {
}
func (d *dataFile) convertAvroValueToIcebergType(v any, fieldID int) any {
+ if v == nil {
Review Comment:
Returning nil here is correct, but it means a null partition value now
reaches eq-delete conflict validation instead of panicking. In
`eqDeletePartitionsToFilter` (conflict_validation.go:545) an
identity-partitioned eq-delete calls `anyToLiteral(p[partFieldID])` with no nil
guard, and `anyToLiteral(nil)` falls to the `default` at
conflict_validation.go:603 and returns `"unsupported partition value type
<nil>"` — which fails the commit. So this trades the panic for a rejected
commit on null identity-partition values. Can we handle nil explicitly in that
path (emit an `IS NULL` term) and add a test that drives it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
