danielcweeks commented on code in PR #15895:
URL: https://github.com/apache/iceberg/pull/15895#discussion_r3390029528
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -222,6 +196,20 @@ default boolean tableExists(SessionContext context,
TableIdentifier ident) {
*/
Table loadTable(SessionContext context, TableIdentifier ident);
+ /**
+ * Load a table with the referenced-by view chain.
+ *
+ * @param context session context
+ * @param ident a table identifier
+ * @param referencedBy ordered list of view identifiers from outermost to
innermost
+ * @return instance of {@link Table} implementation referred by {@code ident}
+ * @throws NoSuchTableException if the table does not exist
+ */
+ default Table loadTable(
+ SessionContext context, TableIdentifier ident, List<TableIdentifier>
referencedBy) {
Review Comment:
Just wanted to add my concern here that we should probably be adding some
sort of `LoadContext` as opposed to specific parameters that are targeted to
this one behavior. Without introducing something that lends itself to
evolution, we make future additions very difficult to plumb through and lots of
dead/deprecated code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
