nazq commented on PR #2566: URL: https://github.com/apache/iceberg-rust/pull/2566#issuecomment-4672639634
Done — pushed the rename. `PlanContext`/`ManifestFileContext`/`ManifestEntryContext` now carry `scan_schema` instead of `snapshot_schema`, and I added a doc comment on `PlanContext::scan_schema` spelling out the current-vs-snapshot distinction you described. Kept the rename scoped to the scan-context chain; the visitor/transformer params downstream still take a `snapshot_schema` arg since those genuinely receive whatever schema the caller passes. Rebased onto current `main` (which picked up the new `FileScanTask::builder()` form) and re-ran the scan tests — all green. Thanks for the thorough trace and the approval! 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
