stevenzwu commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3391368681
##########
core/src/main/java/org/apache/iceberg/EntryStatus.java:
##########
@@ -38,6 +42,10 @@ public int id() {
return id;
}
+ boolean isLive() {
+ return this == EXISTING || this == ADDED || this == MODIFIED;
Review Comment:
+1. Ryan's suggestion is simpler and more maintainable.
this method would just simply `return isLive;`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
