rambleraptor commented on code in PR #1174:
URL: https://github.com/apache/iceberg-go/pull/1174#discussion_r3391824928
##########
catalog/rest/rest.go:
##########
@@ -1327,7 +1394,22 @@ func (r *Catalog) CheckNamespaceExists(ctx
context.Context, namespace table.Iden
return false, err
}
- err := doHead(ctx, r.baseURI, []string{"namespaces",
strings.Join(namespace, namespaceSeparator)},
+ // If the server does not advertise the HEAD existence endpoint, fall
back to
+ // a GET (load) for compatibility with servers that predate it.
+ if r.endpoints != nil && !r.endpoints.contains(endpointNamespaceExists)
{
Review Comment:
Cool, made that fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
