huaxingao commented on code in PR #16292:
URL: https://github.com/apache/iceberg/pull/16292#discussion_r3392761069
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -169,6 +171,13 @@ private boolean supportsParquetBatchReads(ScanTask task) {
}
private boolean supportsParquetBatchReads(Types.NestedField field) {
+ if (field.type().isVariantType()) {
+ return !PropertyUtil.propertyAsBoolean(
Review Comment:
This gates batch reads on the `write.parquet.shred-variants` property. The
property reflects the current write config, not what's in existing files — so a
table that's currently false but still has shredded files (property toggled
later, or files written elsewhere) would take the batch path and silently drop
`typed_value` data. Is "property=false -> no shredded files" a safe assumption?
If so, worth a short comment noting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
