RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r3396756677
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -375,7 +382,17 @@ public boolean purgeTable(Identifier ident) {
String metadataFileLocation =
((HasTableOperations)
table).operations().current().metadataFileLocation();
- boolean dropped = dropTableWithoutPurging(ident);
+ if (isRestCatalog && !isPathIdentifier(ident)) {
+ if (restCatalogPurge) {
+ return icebergCatalog.dropTable(buildIdentifier(ident), true);
+ } else {
+ LOG.warn(
+ "Set '{}' to true to use the REST Catalog's capabilities to
purge the table.",
Review Comment:
```suggestion
"Set '{}' to true to use the REST catalog's capabilities to
purge the table.",
```
nit: lowercase `c` in "REST catalog" to match the `Preconditions` message at
line 802 (`"not a REST catalog"`) and the consistent usage across
`core/src/main/java` (e.g. `RESTClient`, `HTTPClient`, `ConfigResponse`,
`RESTUtil`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
