liucao-dd commented on code in PR #16154:
URL: https://github.com/apache/iceberg/pull/16154#discussion_r3398889820
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -70,6 +70,9 @@ private SparkSQLProperties() {}
// Overrides the advisory partition size
public static final String ADVISORY_PARTITION_SIZE =
"spark.sql.iceberg.advisory-partition-size";
+ // Overrides the split target size for scan planning
+ public static final String SPLIT_SIZE = "spark.sql.iceberg.split-size";
Review Comment:
Should this be `spark.sql.iceberg.read.split-size` instead?
The closest merged precedent is #16088, which added the split-planning
session configs under the read namespace:
- `spark.sql.iceberg.read.adaptive-split-size.enabled`
- `spark.sql.iceberg.read.adaptive-split-size.parallelism`
Since this is the fixed split-size counterpart to adaptive split sizing,
keeping it under `spark.sql.iceberg.read.*` seems more consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
