wombatu-kun commented on code in PR #16513:
URL: https://github.com/apache/iceberg/pull/16513#discussion_r3401173856
##########
.github/workflows/cve-scan.yml:
##########
@@ -27,7 +27,50 @@ on:
- '2.*'
tags:
- 'apache-iceberg-**'
+ paths:
+ - '**'
+ - '!.github/**'
+ - '.github/workflows/cve-scan.yml'
+ - '!.baseline/**'
+ - '!.palantir/**'
+ - '!.gitignore'
+ - '!.asf.yaml'
+ - '!dev/**'
+ - '!docker/**'
+ - '!docs/**'
+ - '!examples/**'
+ - '!site/**'
+ - '!format/**'
+ - '!.gitattributes'
+ - '!**/README.md'
+ - '!AGENTS.md'
+ - '!CONTRIBUTING.md'
+ - '!SECURITY-THREAT-MODEL.md'
+ - '!**/LICENSE'
+ - '!**/NOTICE'
+ - '!doap.rdf'
pull_request:
+ paths:
+ - '**'
+ - '!.github/**'
+ - '.github/workflows/cve-scan.yml'
+ - '!.baseline/**'
+ - '!.palantir/**'
+ - '!.gitignore'
+ - '!.asf.yaml'
+ - '!dev/**'
+ - '!docker/**'
+ - '!docs/**'
+ - '!examples/**'
+ - '!site/**'
+ - '!format/**'
+ - '!.gitattributes'
+ - '!**/README.md'
+ - '!AGENTS.md'
+ - '!CONTRIBUTING.md'
Review Comment:
This pull_request paths list is missing `'!SECURITY-THREAT-MODEL.md'`. The
push list excludes it (line 48), but here line 70 goes straight to
`'!**/LICENSE'` (line 71), so a PR touching only `SECURITY-THREAT-MODEL.md`
still triggers the scan. Add `'!SECURITY-THREAT-MODEL.md'` after this line to
match push - the "both push and pull" fix only landed on push.
##########
.github/workflows/cve-scan.yml:
##########
@@ -27,7 +27,49 @@ on:
- '2.*'
tags:
- 'apache-iceberg-**'
+ paths:
+ - '**'
+ - '!.github/**'
+ - '.github/workflows/cve-scan.yml'
+ - '!.baseline/**'
+ - '!.palantir/**'
+ - '!.gitignore'
+ - '!.asf.yaml'
+ - '!dev/**'
+ - '!docker/**'
+ - '!docs/**'
+ - '!examples/**'
+ - '!site/**'
+ - '!format/**'
+ - '!.gitattributes'
+ - '!**/README.md'
+ - '!AGENTS.md'
+ - '!CONTRIBUTING.md'
Review Comment:
The exclusion only landed in the push paths list (line 48). The pull_request
paths list still goes from `'!CONTRIBUTING.md'` (line 70) directly to
`'!**/LICENSE'` (line 71), so a PR touching only `SECURITY-THREAT-MODEL.md`
still triggers the scan. Add `'!SECURITY-THREAT-MODEL.md'` after line 70 to
skip it on pull_request too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
