sejal-gupta-ksolves commented on code in PR #16768:
URL: https://github.com/apache/iceberg/pull/16768#discussion_r3401609273
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -107,7 +107,18 @@ public CloseableIterator<FileScanTask> iterator() {
}
@Override
- public void close() throws IOException {}
Review Comment:
Exactly. By implementing a functional, thread-safe `close()` method directly
on `ScanTaskIterable`, scanning layers like `RESTTableScan` can natively track
this iterable in their closeable lifecycle groups.
This guarantees that early query cancellations cascade properly to evict the
background pools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
